Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resources for admin tools containers and creating network policies #361

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Demcheck
Copy link

@Demcheck Demcheck commented Feb 5, 2023

What was changed

This PR add option to create NetworkPolicies and add recources for admintools containers.

Why?

In our company we use network policies in k8s clusters how must have option for all services.
Also within out clusters we have Kyverno that checking recources for all containers.

  1. Closes

  2. How was this tested:

It has tested in our k8s cluster.

  1. Any docs updates needed?

I think nothing need to update.

@Demcheck Demcheck requested review from a team as code owners February 5, 2023 16:57
@ngnix
Copy link

ngnix commented Mar 31, 2023

Hey guys, do you have any update?

{{- $serviceValues := index $.Values.server $service }}
- protocol: TCP
port: {{ $serviceValues.service.port }}
{{- end }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this work if fontend, history, matching and worker all share the same port?

@robholland
Copy link
Contributor

I'm happy to work with you on getting this merged, but please rebase against current master branch.

@robholland robholland added the needs revision Team has requested some changes label Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs revision Team has requested some changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants