Skip to content

Commit

Permalink
address pr comments
Browse files Browse the repository at this point in the history
  • Loading branch information
THardy98 committed Feb 3, 2025
1 parent 25059a8 commit 5ff4101
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 13 deletions.
2 changes: 1 addition & 1 deletion src/SleepForDays/Activities.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ namespace TemporalioSamples.SleepForDays;
using Microsoft.Extensions.Logging;
using Temporalio.Activities;

public class SleepForDaysActivities
public class Activities
{
// Stub for an actual implementation for sending emails.
[Activity]
Expand Down
2 changes: 1 addition & 1 deletion src/SleepForDays/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ async Task RunWorkerAsync()
};

// Create an activity instance with some state
var activities = new SleepForDaysActivities();
var activities = new Activities();

// Run worker until cancelled
Console.WriteLine("Running worker");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,28 +6,24 @@ namespace TemporalioSamples.SleepForDays;
[Workflow]
public class SleepForDaysWorkflow
{
private bool isComplete;
private bool complete;

[WorkflowRun]
public async Task RunAsync()
{
isComplete = false;
while (!isComplete)
while (!complete)
{
await Workflow.ExecuteActivityAsync(
(SleepForDaysActivities act) => act.SendEmail("Sleeping for 30 days"),
new() { StartToCloseTimeout = TimeSpan.FromSeconds(10) });
await Task.WhenAny(
(Activities act) => act.SendEmail("Sleeping for 30 days"),
new() { StartToCloseTimeout = TimeSpan.FromDays(30) });
await Workflow.WhenAny(

Check failure on line 19 in src/SleepForDays/SleepForDaysWorkflow.workflow.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (ubuntu-latest)

'Workflow' does not contain a definition for 'WhenAny'

Check failure on line 19 in src/SleepForDays/SleepForDaysWorkflow.workflow.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (ubuntu-latest)

'Workflow' does not contain a definition for 'WhenAny'

Check failure on line 19 in src/SleepForDays/SleepForDaysWorkflow.workflow.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (macos-latest)

'Workflow' does not contain a definition for 'WhenAny'

Check failure on line 19 in src/SleepForDays/SleepForDaysWorkflow.workflow.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (macos-latest)

'Workflow' does not contain a definition for 'WhenAny'
Workflow.DelayAsync(TimeSpan.FromSeconds(30)),
Workflow.WaitConditionAsync(() => isComplete));
Workflow.WaitConditionAsync(() => complete));
}

Workflow.Logger.LogInformation("done!");
}

[WorkflowSignal]
public async Task CompleteAsync()
{
isComplete = true;
}
public async Task CompleteAsync() => complete = true;
}

0 comments on commit 5ff4101

Please sign in to comment.