Skip to content

Commit

Permalink
Pin staticcheck to v0.3.3 (#1031)
Browse files Browse the repository at this point in the history
The latest version of staticcheck (0.4.0 as of 3 Feb 2023) scans
dependencies (?) and incorrectly detects that the
proxy.WorkflowServiceProxyOptions.Client field is unused in api-go. We
will pin to the previous version for now but be advised this version is
known not to work with go1.20.
  • Loading branch information
Matt McShane committed Feb 3, 2023
1 parent a9a4baa commit 1ede668
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,12 @@ vet: $(ALL_SRC)
done;

staticcheck: $(ALL_SRC)
go install honnef.co/go/tools/cmd/staticcheck@latest
# The latest version of staticcheck (0.4.0 as of 3 Feb 2023) scans
# dependencies (?) and incorrectly detects that the
# proxy.WorkflowServiceProxyOptions.Client field is unused in api-go. We
# will pin to the previous version for now but be advised this version is
# known not to work with go1.20.
go install honnef.co/go/tools/cmd/[email protected]
@for dir in $(MOD_DIRS); do \
(cd "$$dir" && echo "In $$dir" && staticcheck ./...) || exit 1; \
done;
Expand Down

0 comments on commit 1ede668

Please sign in to comment.