Add missing activity failure metric (#479)

temporalio · Jun 24, 2021 · 754c666 · 754c666
1 parent e8455cb
commit 754c666
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/internal/internal_task_pollers.go b/internal/internal_task_pollers.go
@@ -873,10 +873,15 @@ func (atp *activityTaskPoller) ProcessTask(task interface{}) error {
 	executionStartTime := time.Now()
 	// Process the activity task.
 	request, err := atp.taskHandler.Execute(atp.taskQueueName, activityTask.task)
+	// err is returned in case of internal failure, such as unable to propagate context or context timeout.
 	if err != nil {
 		activityMetricsScope.Counter(metrics.ActivityExecutionFailedCounter).Inc(1)
 		return err
 	}
+	// in case if activity execution failed, request should be of type RespondActivityTaskFailedRequest
+	if _, ok := request.(*workflowservice.RespondActivityTaskFailedRequest); ok {
+		activityMetricsScope.Counter(metrics.ActivityExecutionFailedCounter).Inc(1)
+	}
 	activityMetricsScope.Timer(metrics.ActivityExecutionLatency).Record(time.Since(executionStartTime))
 
 	if request == ErrActivityResultPending {

diff --git a/test/integration_test.go b/test/integration_test.go
@@ -241,6 +241,7 @@ func (ts *IntegrationTestSuite) TestActivityRetryOnError() {
 	ts.assertMetricsCounters(
 		"temporal_request", 7,
 		"temporal_request_attempt", 7,
+		"temporal_activity_execution_failed", 2,
 		"temporal_workflow_task_queue_poll_succeed", 1,
 		"temporal_long_request", 8,
 		"temporal_long_request_attempt", 8,