Skip to content

Commit

Permalink
Rename connectParameters to dialParameters (#133)
Browse files Browse the repository at this point in the history
  • Loading branch information
shawnhathaway committed May 14, 2020
1 parent e6070f4 commit c2c1f89
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions internal/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,7 @@ func NewClient(options ClientOptions) (Client, error) {
options.HostPort = LocalHostPort
}

connection, err := dial(newConnectionParams(&options))
connection, err := dial(newDialParameters(&options))

if err != nil {
return nil, err
Expand All @@ -564,8 +564,8 @@ func NewClient(options ClientOptions) (Client, error) {
return NewServiceClient(workflowservice.NewWorkflowServiceClient(connection), connection, options), nil
}

func newConnectionParams(options *ClientOptions) connectionParameters {
return connectionParameters{
func newDialParameters(options *ClientOptions) dialParameters {
return dialParameters{
UserOptions: options.ConnectionOptions,
HostPort: options.HostPort,
RequiredInterceptors: requiredInterceptors(options.MetricsScope),
Expand Down Expand Up @@ -615,7 +615,7 @@ func NewNamespaceClient(options ClientOptions) (NamespaceClient, error) {
options.HostPort = LocalHostPort
}

connection, err := dial(newConnectionParams(&options))
connection, err := dial(newDialParameters(&options))
if err != nil {
return nil, err
}
Expand Down
6 changes: 3 additions & 3 deletions internal/grpc_dialer.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ type (
TLS *tls.Config
}

// connectionParameters are passed to GRPCDialer and must be used to create gRPC connection.
connectionParameters struct {
// dialParameters are passed to GRPCDialer and must be used to create gRPC connection.
dialParameters struct {
HostPort string
UserOptions ConnectionOptions
RequiredInterceptors []grpc.UnaryClientInterceptor
Expand All @@ -60,7 +60,7 @@ const (
defaultServiceConfig = `{"loadBalancingConfig": [{"round_robin":{}}]}`
)

func dial(params connectionParameters) (*grpc.ClientConn, error) {
func dial(params dialParameters) (*grpc.ClientConn, error) {
grpcSecurityOptions := grpc.WithInsecure()
if params.UserOptions.TLS != nil {
grpcSecurityOptions = grpc.WithTransportCredentials(credentials.NewTLS(params.UserOptions.TLS))
Expand Down

0 comments on commit c2c1f89

Please sign in to comment.