Nexus Interceptors #2244
Draft
Nexus Interceptors #2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Nexus Workflow API
Nexus worker support
Nexus workflow operation support
Add Nexus support to TestWorkflowExtension
Add helper for Nexus to Kotlin
Springboot auto discovery support for NexusServices
|
|
||
| public void writeSpanContextToHeader( | ||
| SpanContext spanContext, Map<String, String> header, Tracer tracer) { | ||
| tracer.inject(spanContext, Format.Builtin.HTTP_HEADERS, new TextMapAdapter(header)); |
There was a problem hiding this comment.
We can't use the same serialization strategy we use for other operations because the Headers are only a String to String map.
Quinn-With-Two-Ns
force-pushed
the
nexus
branch
from
eb77b1e
to
aafddcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Nexus worker interceptors and tracing support
Note: Marking as draft as I don't think this is the approach we should take. Since the Nexus SDK controls deserialization the UX of this interceptor is very different from all other interceptors.