Ensure heartbeat details aren't cleared #2460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Mar 26, 2025
Comment on lines
+65
to
+68
| assertEquals( | ||
| "heartbeat details", | ||
| DefaultDataConverter.STANDARD_INSTANCE.fromPayloads( | ||
| 0, activityHeartbeats.poll(), String.class, String.class)); |
There was a problem hiding this comment.
I assume this is the assertion that would have failed without the change because it'd still have 2 in the queue, but even the second would not be present due to overwrite (just kinda proving I read it and understand it heh)
There was a problem hiding this comment.
Yes this fails without the test server change
Quinn-With-Two-Ns
force-pushed
the
issue-2459
branch
from
d514bd4 to
d84e13b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2459