Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when failing to convert failure #727

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

cretz
Copy link
Member

@cretz cretz commented Jan 13, 2025

What was changed

Fixed an issue where the application_failure_info wasn't being set when failing to convert failures

Checklist

  1. Closes [Bug] Issue when failing to build activity failure #685

@cretz cretz requested a review from a team as a code owner January 13, 2025 14:16
…rsion-failure

# Conflicts:
#	tests/worker/test_workflow.py
@cretz
Copy link
Member Author

cretz commented Jan 21, 2025

@dandavison - anything needed here? Figure this is a simple change, so will merge in a bit unless there is objection

Copy link
Contributor

@dandavison dandavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cretz cretz merged commit 154aab9 into temporalio:main Jan 21, 2025
13 checks passed
@cretz cretz deleted the failure-conversion-failure branch January 21, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Issue when failing to build activity failure
3 participants