fix(workflow): Clearly diffentiate WFT failures resulting from unhandle Promise rejection #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjameswh
force-pushed
the
unhandled-promise-rejections
branch
from
c028018 to
8cc294e
Compare
bergundy
reviewed
Jan 24, 2025
bergundy
approved these changes
Feb 7, 2025
THardy98
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
The sandbox was previously converting all non-TemporalFailure errors thrown while processing a Workflow Activation into unhandled promise rejections, to be caught elsewhere. This was done intentionally and technically worked correctly most of the time, but made it impossible to differentiate errors that were indeed uncaught promise rejections, occasionally resulting in hard to diagnose errors (see [Bug] Unhandled promise rejections results in hard to diagnose WFT failure #1039). It also resulted in some incorrect behaviors in uncommon/rare use cases.
This PR introduces a cleaner way to propagate non-TemporalFailures errors up, thus avoiding the intentional use of Unhandled Promise Rejection for that purpose.
Also, errors resulting from actual unhandled promise rejections now get wrapped in a
UnhandledRejectionError, making this fact clear in error messages that are reported in logs, Workflow History, and UI.Fixes #1039.