use proto field path for Cloud Run scale update mask#77
Open
gcristea-temporal wants to merge 1 commit into
Open
use proto field path for Cloud Run scale update mask#77gcristea-temporal wants to merge 1 commit into
gcristea-temporal wants to merge 1 commit into
Conversation
Collaborator
|
Is this a real problem given it is a constant we are dealing with? |
02strich
approved these changes
Jul 9, 2026
02strich
left a comment
Collaborator
There was a problem hiding this comment.
After chatting with the author, it is a real thing b/c Google docs are buggy and so figuring out the right constant is unreliable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Use the proto field path
scaling.manual_instance_countand build the mask viafieldmaskpb.Newso an invalid path panics at load instead of misbehaving silently at runtime.Why?
UpdateWorkerSetSizesent the scale update mask asscaling.manualInstanceCount(camelCase JSON name).Cloud Run silently ignores an unknown mask path and applies the sparse WorkerPool wholesale, resetting the pool's runtime serviceAccount to the project default compute SA — which surfaces as an
iam.serviceAccounts.actAsPermissionDenied on the deployer.Checklist
Closes
How was this tested: