Skip to content

use proto field path for Cloud Run scale update mask#77

Open
gcristea-temporal wants to merge 1 commit into
mainfrom
field-mask-fix
Open

use proto field path for Cloud Run scale update mask#77
gcristea-temporal wants to merge 1 commit into
mainfrom
field-mask-fix

Conversation

@gcristea-temporal

Copy link
Copy Markdown
Contributor

What was changed

Use the proto field path scaling.manual_instance_count and build the mask via fieldmaskpb.New so an invalid path panics at load instead of misbehaving silently at runtime.

Why?

UpdateWorkerSetSize sent the scale update mask as scaling.manualInstanceCount (camelCase JSON name).

Cloud Run silently ignores an unknown mask path and applies the sparse WorkerPool wholesale, resetting the pool's runtime serviceAccount to the project default compute SA — which surfaces as an iam.serviceAccounts.actAs PermissionDenied on the deployer.

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@gcristea-temporal gcristea-temporal requested a review from a team as a code owner July 9, 2026 16:58
@02strich

02strich commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Is this a real problem given it is a constant we are dealing with?

@02strich 02strich left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After chatting with the author, it is a real thing b/c Google docs are buggy and so figuring out the right constant is unreliable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants