Add API key support for the worker-controller #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shivs11
commented
Sep 30, 2025
| if config.RolloutStrategy.Gate == nil || | ||
| status.CurrentVersion == nil || | ||
| status.CurrentVersion.BuildID == status.TargetVersion.BuildID || | ||
| (status.CurrentVersion != nil && status.CurrentVersion.BuildID == status.TargetVersion.BuildID) || |
There was a problem hiding this comment.
This is required but is part of a different open PR: #148
Shivs11
commented
Sep 30, 2025
internal/demo/util/client.go
Outdated
| if _, err := c.CheckHealth(context.Background(), &client.CheckHealthRequest{}); err != nil { | ||
| panic(err) | ||
| } | ||
| // if _, err := c.CheckHealth(context.Background(), &client.CheckHealthRequest{}); err != nil { |
There was a problem hiding this comment.
I found out that when paired with API keys, this API call does not work - the only other call that could work is GetSystemInfo but I am not totally sure if we require this over here since we would be notified from client.Dial if anything has gone wrong between connecting our client to the server accepting our client connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Checklist
Closes
Add API Keys support #144
How was this tested: