Optimize Docker builds: Add .dockerignore, improve caching, and enhance Dockerfile structure #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilydoar
force-pushed
the
dockerfile-improve
branch
from
7a8ee25 to
ba28ef9
Compare
lilydoar
force-pushed
the
dockerfile-improve
branch
5 times, most recently
from
70debb5 to
91a8e87
Compare
carlydf
reviewed
Nov 18, 2025
Collaborator
carlydf
left a comment
carlydf
left a comment
There was a problem hiding this comment.
looks good I just want to see the build work
| check-latest: true | ||
|
|
||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@f95db51fddba0c2d1ec667646a06c2ce06100226 # v3.0.0 |
Collaborator
There was a problem hiding this comment.
maybe this is why the skaffold build is breaking? not sure
| run: | | ||
| skaffold build --profile worker-controller --push=false | ||
| env: | ||
| DOCKER_BUILDKIT: 1 |
Collaborator
There was a problem hiding this comment.
it seems like somehow this isn't being passed to the skaffold build job, which is failing with "docker build failure: the --mount option requires BuildKit. Refer to https://docs.docker.com/go/buildkit/ to learn how to build images with BuildKit enabled. Please fix the Dockerfile and try again.."
lilydoar
force-pushed
the
dockerfile-improve
branch
from
91a8e87 to
a2e4baa
Compare
lilydoar
force-pushed
the
dockerfile-improve
branch
from
a2e4baa to
62b059f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.dockerignorefile to exclude unnecessary files from Docker context