test(mixedbrain): add scheduler_stress scenario and server log scanning#10928
Merged
Conversation
Run the scheduler_stress Omes scenario alongside throughput_stress in the mixed brain test. The two scenarios run concurrently, each in its own namespace (and with a distinct run ID / task queue) so their load stays isolated while both exercise the mixed-version cluster. Also add a post-run scan of both server logs for panics, soft-assertion failures, and inconsistent metric descriptors. This catches problems that don't surface as a process exit (recovered panics, soft asserts) - notably relevant since scheduler_stress swallows its own operation errors. Scanners are pluggable via a logLineValidator interface. Servers are stopped before scanning so their logs are fully flushed; serverProcess.stop is now idempotent to coexist with the cleanup hooks.
Make scanServerLogs a pure function returning failure messages instead of threading testing.TB through it; the caller reports them. This removes the mockT test shim. Also drop the unused validatorFunc adapter, use the existing util.TruncateUTF8 helper instead of a local one, and inline the single-caller per-file scan.
stephanos
approved these changes
Jul 7, 2026
- Tighten the panic log check to "panic:" to avoid false positives. - Mark the log scanner unit tests as parallel. - Hoist the scenarios slice to a package-level var so it gives a clear view of what's tested and drives namespace registration; derive each scenario's run ID at the call site instead of storing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
scheduler_stressOmes scenario to the mixed brain test, and scans both server logs for panics and soft-assertion failures after the run.Worth calling out (not obvious from the diff):
enable-chasm-scheduleris left at its default (on).scheduler_stress, which swallows its own operation errors. The panic/assertion exclude lists are a starting point and may need tuning after a real CI run.