reserve delete_on_completion #7036
Open
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ychebotarev
approved these changes
Dec 27, 2024
bergundy
approved these changes
Dec 27, 2024
bergundy
reviewed
Dec 27, 2024
| @@ -676,8 +676,7 @@ message NexusOperationInfo { | |||
| // Operation name. | |||
| string operation = 3; | |||
|
|
|||
| // If set the state machine will remove itself from the HSM tree on completion. | |||
| bool delete_on_completion = 4; | |||
There was a problem hiding this comment.
I'd just add a comment saying what was here and why it's reserved for future context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Set delete_on_completion to reserved
Why?
delete_on_completion is no longer needed
How did you test it?
make
Potential risks
Documentation
Is hotfix candidate?
No