Separate some interfaces from implementation #7042
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Extract interface definitions into separate sub-module.
Why?
Part of very long (not even sure if I will not give up) chain of refactoring efforts to improve overall design.
MutableState extends those interfaces. But they are defined alongside implementations, and some other structures.
As the result this introduce long chains of dependencies for MutableState, not needed by MutableState itself.
Eventually this leads to some unwanted "cycling dependencies" along the path to refactoring.
How did you test it?
Unit tests