use transition history if enabled when long poll history #7185
+2,761
−2,589
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| // The MIT License | ||
| // | ||
| // Copyright (c) 2024 Temporal Technologies Inc. All rights reserved. | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in | ||
| // all copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| // THE SOFTWARE. | ||
|
|
||
| package transitionhistory | ||
|
|
||
| import ( | ||
| persistencespb "go.temporal.io/server/api/persistence/v1" | ||
| "go.temporal.io/server/common" | ||
| ) | ||
|
|
||
| func CopyVersionedTransitions( | ||
| transitions []*persistencespb.VersionedTransition, | ||
| ) []*persistencespb.VersionedTransition { | ||
| if transitions == nil { | ||
| return nil | ||
| } | ||
| copied := make([]*persistencespb.VersionedTransition, len(transitions)) | ||
| for i, t := range transitions { | ||
| copied[i] = CopyVersionedTransition(t) | ||
| } | ||
| return copied | ||
| } | ||
|
|
||
| func CopyVersionedTransition( | ||
| transition *persistencespb.VersionedTransition, | ||
| ) *persistencespb.VersionedTransition { | ||
| if transition == nil { | ||
| return nil | ||
| } | ||
| return common.CloneProto(transition) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,6 +34,7 @@ import ( | |
| "go.temporal.io/api/workflowservice/v1" | ||
| historyspb "go.temporal.io/server/api/history/v1" | ||
| "go.temporal.io/server/api/historyservice/v1" | ||
| persistencespb "go.temporal.io/server/api/persistence/v1" | ||
| tokenspb "go.temporal.io/server/api/token/v1" | ||
| "go.temporal.io/server/common" | ||
| "go.temporal.io/server/common/failure" | ||
|
|
@@ -76,7 +77,8 @@ func Invoke( | |
| expectedNextEventID int64, | ||
| currentBranchToken []byte, | ||
| versionHistoryItem *historyspb.VersionHistoryItem, | ||
| versionedTransition *persistencespb.VersionedTransition, | ||
| ) ([]byte, string, int64, int64, bool, *historyspb.VersionHistoryItem, *persistencespb.VersionedTransition, error) { | ||
| response, err := api.GetOrPollMutableState( | ||
| ctx, | ||
| shardContext, | ||
|
|
@@ -86,29 +88,38 @@ func Invoke( | |
| ExpectedNextEventId: expectedNextEventID, | ||
| CurrentBranchToken: currentBranchToken, | ||
| VersionHistoryItem: versionHistoryItem, | ||
| VersionedTransition: versionedTransition, | ||
| }, | ||
| workflowConsistencyChecker, | ||
| eventNotifier, | ||
| ) | ||
| if err != nil { | ||
| return nil, "", 0, 0, false, nil, nil, err | ||
| } | ||
|
|
||
| isWorkflowRunning := response.GetWorkflowStatus() == enumspb.WORKFLOW_EXECUTION_STATUS_RUNNING | ||
| currentVersionHistory, err := versionhistory.GetCurrentVersionHistory(response.GetVersionHistories()) | ||
| if err != nil { | ||
| return nil, "", 0, 0, false, nil, nil, err | ||
| } | ||
| lastVersionHistoryItem, err := versionhistory.GetLastVersionHistoryItem(currentVersionHistory) | ||
| if err != nil { | ||
| return nil, "", 0, 0, false, nil, nil, err | ||
| } | ||
|
|
||
| var lastVersionedTransition *persistencespb.VersionedTransition | ||
| transitionHistory := response.GetTransitionHistory() | ||
| if transitionHistory != nil { | ||
| lastVersionedTransition = transitionHistory[len(transitionHistory)-1] | ||
| } | ||
|
Comment on lines
+110
to
+114
There was a problem hiding this comment. nit: make this a util function as well for getting the last versioned transition? I think I have seen this logic in couple of places. |
||
|
|
||
| return response.CurrentBranchToken, | ||
| response.Execution.GetRunId(), | ||
| response.GetLastFirstEventId(), | ||
| response.GetNextEventId(), | ||
| isWorkflowRunning, | ||
| lastVersionHistoryItem, | ||
| lastVersionedTransition, | ||
| nil | ||
| } | ||
|
|
||
|
|
@@ -140,8 +151,8 @@ func Invoke( | |
| if !isCloseEventOnly { | ||
| queryNextEventID = continuationToken.GetNextEventId() | ||
| } | ||
| continuationToken.BranchToken, _, lastFirstEventID, nextEventID, isWorkflowRunning, continuationToken.VersionHistoryItem, continuationToken.VersionedTransition, err = | ||
| queryHistory(namespaceID, execution, queryNextEventID, continuationToken.BranchToken, continuationToken.VersionHistoryItem, continuationToken.VersionedTransition) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
@@ -154,8 +165,8 @@ func Invoke( | |
| if !isCloseEventOnly { | ||
| queryNextEventID = common.FirstEventID | ||
| } | ||
| continuationToken.BranchToken, runID, lastFirstEventID, nextEventID, isWorkflowRunning, continuationToken.VersionHistoryItem, continuationToken.VersionedTransition, err = | ||
| queryHistory(namespaceID, execution, queryNextEventID, nil, nil, nil) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,12 +34,14 @@ import ( | |
| "go.temporal.io/api/serviceerror" | ||
| enumsspb "go.temporal.io/server/api/enums/v1" | ||
| historyspb "go.temporal.io/server/api/history/v1" | ||
| persistencespb "go.temporal.io/server/api/persistence/v1" | ||
| "go.temporal.io/server/common" | ||
| "go.temporal.io/server/common/clock" | ||
| "go.temporal.io/server/common/collection" | ||
| "go.temporal.io/server/common/definition" | ||
| "go.temporal.io/server/common/metrics" | ||
| "go.temporal.io/server/common/namespace" | ||
| "go.temporal.io/server/common/persistence/transitionhistory" | ||
| "go.temporal.io/server/common/persistence/versionhistory" | ||
| ) | ||
|
|
||
|
|
@@ -66,6 +68,7 @@ type ( | |
| WorkflowState enumsspb.WorkflowExecutionState | ||
| WorkflowStatus enumspb.WorkflowExecutionStatus | ||
| VersionHistories *historyspb.VersionHistories | ||
| TransitionHistory []*persistencespb.VersionedTransition | ||
| } | ||
|
|
||
| NotifierImpl struct { | ||
|
|
@@ -100,6 +103,7 @@ func NewNotification( | |
| workflowState enumsspb.WorkflowExecutionState, | ||
| workflowStatus enumspb.WorkflowExecutionStatus, | ||
| versionHistories *historyspb.VersionHistories, | ||
| transitionHistory []*persistencespb.VersionedTransition, | ||
| ) *Notification { | ||
|
|
||
| return &Notification{ | ||
|
|
@@ -115,6 +119,7 @@ func NewNotification( | |
| WorkflowState: workflowState, | ||
| WorkflowStatus: workflowStatus, | ||
| VersionHistories: versionhistory.CopyVersionHistories(versionHistories), | ||
| TransitionHistory: transitionhistory.CopyVersionedTransitions(transitionHistory), | ||
yycptt marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,6 +35,7 @@ import ( | |
| enumspb "go.temporal.io/api/enums/v1" | ||
| enumsspb "go.temporal.io/server/api/enums/v1" | ||
| historyspb "go.temporal.io/server/api/history/v1" | ||
| persistencespb "go.temporal.io/server/api/persistence/v1" | ||
| "go.temporal.io/server/common/clock" | ||
| "go.temporal.io/server/common/definition" | ||
| "go.temporal.io/server/common/metrics" | ||
|
|
@@ -98,7 +99,11 @@ func (s *notifierSuite) TestSingleSubscriberWatchingEvents() { | |
| versionHistoryItem := versionhistory.NewVersionHistoryItem(nextEventID-1, 1) | ||
| currentVersionHistory := versionhistory.NewVersionHistory(branchToken, []*historyspb.VersionHistoryItem{versionHistoryItem}) | ||
| versionHistories := versionhistory.NewVersionHistories(currentVersionHistory) | ||
| transitionHistory := []*persistencespb.VersionedTransition{ | ||
| {NamespaceFailoverVersion: 1234, TransitionCount: 1024}, | ||
| {TransitionCount: 1025}, | ||
| } | ||
| historyEvent := NewNotification(namespaceID, execution, lastFirstEventID, lastFirstEventTxnID, nextEventID, previousStartedEventID, workflowState, workflowStatus, versionHistories, transitionHistory) | ||
| timerChan := time.NewTimer(time.Second * 2).C | ||
|
|
||
| subscriberID, channel, err := s.notifier.WatchHistoryEvent(definition.NewWorkflowKey(namespaceID, execution.GetWorkflowId(), execution.GetRunId())) | ||
|
|
@@ -133,7 +138,11 @@ func (s *notifierSuite) TestMultipleSubscriberWatchingEvents() { | |
| versionHistoryItem := versionhistory.NewVersionHistoryItem(nextEventID-1, 1) | ||
| currentVersionHistory := versionhistory.NewVersionHistory(branchToken, []*historyspb.VersionHistoryItem{versionHistoryItem}) | ||
| versionHistories := versionhistory.NewVersionHistories(currentVersionHistory) | ||
| transitionHistory := []*persistencespb.VersionedTransition{ | ||
| {NamespaceFailoverVersion: 1234, TransitionCount: 1024}, | ||
| {TransitionCount: 1025}, | ||
| } | ||
| historyEvent := NewNotification(namespaceID, execution, lastFirstEventID, lastFirstEventTxnID, nextEventID, previousStartedEventID, workflowState, workflowStatus, versionHistories, transitionHistory) | ||
| timerChan := time.NewTimer(time.Second * 5).C | ||
|
|
||
| subscriberCount := 100 | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -435,7 +435,8 @@ func (s *engineSuite) TestGetMutableStateLongPoll_CurrentBranchChanged() { | |
| int64(1), | ||
| enumsspb.WORKFLOW_EXECUTION_STATE_CREATED, | ||
| enumspb.WORKFLOW_EXECUTION_STATUS_RUNNING, | ||
| ms.GetExecutionInfo().GetVersionHistories(), | ||
| ms.GetExecutionInfo().GetTransitionHistory()), | ||
| ) | ||
| } | ||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.