try adding eventually #8420
Closed
try adding eventually #8420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaptersix
commented
Oct 2, 2025
| } | ||
| s.Logger.Info("workflow completed", | ||
| // not the actual workflow ID | ||
| tag.WorkflowID("TestBufferedEventsMutableStateSizeLimit")) |
There was a problem hiding this comment.
@stephanos is there a better way to tag this?
There was a problem hiding this comment.
Tag is good 👍 Why not make it debug; since we know we have debug logs for tests enabled. This way production stays clean.
chaptersix
deleted the
alex/flat_TestBufferedEventsMutableStateSizeLimit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added some log statements to the TestMaxBufferedEventsLimit functional test to help debug why the test is failing. I also added require.Eventually blocks to repeatedly check the conditions.
Why?
This tests has been very flaky but I can't seem to reproduce the failure in single tests runs or locally. Logs are too verbose to glean anything meaningful from them.
I also tried visualizing the traces and nothing seemed to stick out. (Could just be me). Hopefully these changes either fix the issue or make it easier to see what's happening.
How did you test it?