Add more softassert.UnexpectedInternalErr #8456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
changed the title
stephanos
force-pushed
the
internal-assertions
branch
from
9daf1da to
d6bc337
Compare
spkane31
approved these changes
Oct 30, 2025
| if s.requestEagerStart() && workflowTaskInfo == nil { | ||
| return nil, serviceerror.NewInternal("unexpected error: mutable state did not have a started workflow task") | ||
| return nil, softassert.UnexpectedInternalErr( | ||
| s.shardContext.GetLogger(), |
There was a problem hiding this comment.
only comment, do we rely on error strings anywhere (we shouldn't imo) but if so we shouldn't change this
There was a problem hiding this comment.
I don't think so; but I can add it back, doesn't hurt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Replace a few
serviceerror.NewInternalwithsoftassert.UnexpectedInternalErr.Why?
Catch these issues in CICD and other testing.
How did you test it?