Change DeserializeComponentRef to return error on empty input #8707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
Nov 26, 2025
yycptt
reviewed
Nov 26, 2025
chasm/ref.go
Outdated
| // Provides caller the access to information including ExecutionKey, Archetype, and ShardingKey. | ||
| func DeserializeComponentRef(data []byte) (ComponentRef, error) { | ||
| if len(data) == 0 { | ||
| return ComponentRef{}, serviceerror.NewInternal("empty chasm component ref") |
Member
There was a problem hiding this comment.
if we are using service error, let's switch to InvalidArgument.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // Provides caller the access to information including ExecutionKey, Archetype, and ShardingKey. | ||
| func DeserializeComponentRef(data []byte) (ComponentRef, error) { | ||
| if len(data) == 0 { | ||
| return ComponentRef{}, errors.New("empty chasm component ref") |
There was a problem hiding this comment.
Bug: Should use InvalidArgument instead of errors.New (Bugbot Rules)
The error returned for empty input uses errors.New instead of serviceerror.NewInvalidArgument. The PR discussion explicitly requested switching to InvalidArgument, and this matches the codebase pattern for invalid input validation as seen in path_encoder.go and visibility.go.
yycptt
reviewed
Nov 26, 2025
| // Provides caller the access to information including ExecutionKey, Archetype, and ShardingKey. | ||
| func DeserializeComponentRef(data []byte) (ComponentRef, error) { | ||
| if len(data) == 0 { | ||
| return ComponentRef{}, errors.New("empty chasm component ref") |
Member
There was a problem hiding this comment.
This will cause unnecessary retries so I can't approve it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
DeserializeComponentRefgiven empty input yields a zero-valueComponentRef. Although this matches the behavior of protoUnmarshal, we don't want to support empty serialized refs. A zero-valueComponentRefcompares less than other values, but it's otherwise mostly invalid (and can't be serialized).Note
Make
DeserializeComponentReferror on empty input and add tests for nil/empty cases.DeserializeComponentRef: Return error on empty input (len(data) == 0); adderrorsimport.TestSerializeDeserializeto assert errors forniland empty byte slices; retain serialization roundtrip checks.Written by Cursor Bugbot for commit f968d82. This will update automatically on new commits. Configure here.