Skip to content

Emit error log if deregistered search attribute in chasm vis task #8715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
awln-temporal merged 2 commits into from
Dec 1, 2025
Merged

Emit error log if deregistered search attribute in chasm vis task #8715

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d9973d
Emit error log if deregistered search attribute in chasm vis task
awln-temporal Nov 26, 2025
fdab724
update comment
awln-temporal Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion service/history/visibility_queue_task_executor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (
"go.temporal.io/server/common/definition"
"go.temporal.io/server/common/dynamicconfig"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/log/tag"
"go.temporal.io/server/common/metrics"
"go.temporal.io/server/common/namespace"
"go.temporal.io/server/common/payload"
Expand Down Expand Up @@ -409,7 +410,10 @@ func (t *visibilityQueueTaskExecutor) processChasmTask(
for alias, value := range aliasedSearchAttributes {
fieldName, err := searchAttributesMapper.GetFieldName(alias, namespaceEntry.Name().String())
if err != nil {
return err
// INFO: To reach here, either the search attribute has been deregistered before task execution, which is valid behavior,
// or the upserted search attribute is incorrectly mapped, indicating possible bug in application code.
Copy link
Member

@bergundy bergundy Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYM incorrectly mapped? Do you mean that there's a bug in the frontend code?

There's another cause for this that we discussed earlier. The search attribute mapping may have propagation delays to the history node executing this task.
We already ensure that all search attributes are mappable on the frontend.

Copy link
Contributor Author

@awln-temporal awln-temporal Nov 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the case of eager workflows, following executions bypassed frontend validators. error message is more specific now.

t.logger.Error("Failed to get field name for alias, ignoring search attribute", tag.NewStringTag("alias", alias), tag.Error(err))
continue
}
searchattributes[fieldName] = value
}
Expand Down
Loading