Metrics for the size of the header field #8717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
reviewed
Nov 27, 2025
Member
There was a problem hiding this comment.
Looks like you missed workflow update headers.
I think all of the commands are covered by I would double check.
Look here for all of the places where header is referenced.
Maybe also inspect the header in the CreateSchedule and UpdateSchedule` APIs in the action to start a workflow.
| operation string, | ||
| ) error { | ||
| config := shard.GetConfig() | ||
| logger := shard.GetLogger() | ||
| throttledLogger := shard.GetThrottledLogger() | ||
| namespaceName := namespaceEntry.Name().String() | ||
|
|
||
| metricsHandler := interceptor.GetMetricsHandlerFromContext(ctx, logger).WithTags(metrics.CommandTypeTag(operation)) | ||
| metrics.HeaderSize.With(metricsHandler).Record(int64(workflowHeaderSize)) |
Member
There was a problem hiding this comment.
Why emit this both on the history and frontend?
Contributor
Author
There was a problem hiding this comment.
I tried to emit this one close to where the payload/memo sizes are being enforced (right after this). Also I don't think this is emitted for start workflow execution requests specifically in the frontend.
simvlad
force-pushed
the
simvlad/track-size-header-user-metadata
branch
from
1861fcb to
86d7d30
Compare
bergundy
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Start to track the size of the header field in the requests
Why?
There are few reasons to start tracking the header size. First, it helps to picture the size of the request used by header field. Second, unlike payload and memo fields, we currently do not enforce the size of the header size. Better visibility into its size will determine at what level we would need to set up the enforcement.
How did you test it?
samples-go/ctxpropagationand checked that the header size metric is populated in PrometheusPotential risks
No