This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Set buildvcs flag to false in docker build. #157
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I added a
-buildvcs=false
flag to thego build
step inside the dockerfile.Why?
This is a workaround to #156
I'm not sure if this is the best way to do this, but it does work.
How did you test it?
I ran
docker build .
before and after the change.Potential risks
This may strip VCS information that someone is using, I am not sure if it is necessary to use this flag in the docker image.
Is hotfix candidate?
No