Consistent with node-semver #375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| new.gsub specifier, '<' | ||
| else | ||
| new | ||
| end |
There was a problem hiding this comment.
How does this behave for cases where the previous version segment is multiple digits (e.g. <= 2.99.x)?
|
Great work, and thanks for the thorough test cases! I had a few comments. Going to look into the Travis CI failures now. |
|
I really doubt this change is what's breaking that integration test. I won't consider that blocking for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds test cases and edge case handling to the Build::Utils#fix_version_string method when version string is like
>1.4.xor<=1.4.xin source Bower packages.Please see also #263.