Skip to content

Conversation

@apkille
Copy link

@apkille apkille commented Aug 29, 2025

These unfolding schemes complement the already implemented :interleaved and :fused schemes. I wrote them up for a project testing the performance of different quantics bases for multivariate functions in different settings. It's possible they could be of use to others. If the package maintainers disagree and want to close this PR, that's perfectly fine! If it gets merged I can follow up with a PR to QuanticsTCI.jl for support in the TCI interface.

@rittermarc
Copy link
Member

Hi @apkille , and thank you for this pull request!

Unfortunately, it has a bit of an inopportune timing, since we're working on merging #21, which enables users of this library to choose the index order freely. The schemes :fused and :interleaved in the new implementation will just be shorthands to set up corresponding index orders, and we can certainly add your :serial and :meander keywords there.

If it's ok with you, I'll keep this pull request open for now. I'll work on merging #21 first, then implement your keywords, which have well-chosen names, and use your tests for the newer implementation.

@rittermarc rittermarc self-assigned this Sep 4, 2025
@apkille
Copy link
Author

apkille commented Sep 4, 2025

Yep, that's OK with me! I will also submit the supporting PR for the unfolding schemes with QuanticsTCI.jl.

By the way, the packages in this GitHub org are very impressive and fast. Using them makes my life a whole lot easier :)

@shinaoka
Copy link
Member

#21 has been merged into the main. How should we proceed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants