Refactor: split MatrixCI/TensorTrain + docs fixes #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure docs env develops local T4ATensorCI (and local deps when present) and avoid fragile @ref links in docs/extension docstrings.
shinaoka
changed the title
- Grant contents: write for Documenter gh-pages deployment\n- Work around registry UUID mismatch by developing T4AMatrixCI/T4ATensorTrain from GitHub in CI (temporary)
Pkg.develop does not support rev=; use Pkg.add(PackageSpec(url=..., rev=...)) so CI can override registry versions.
Pkg.add needs General for std deps like QuadGK; add default registries before adding git-based deps.
Stop defining duplicate ITensor/T4AITensorCompat conversion methods in T4ATensorCI extensions (they live in T4ATensorTrain ext/). Also disable Aqua persistent_tasks to avoid registry-resolution flakiness in CI.
Conversion implementations are delegated to T4ATensorTrain extensions; remove now-unused files from T4ATensorCI to avoid confusion and dead code.
Fix docs CI resolution issues by instantiating docs/ with T4AMatrixCI and T4ATensorTrain added via git URL before julia-docdeploy runs.
Avoid kwcall when forwarding evaluate to T4AMatrixCI for MatrixCI/MatrixACA. This fixes JET failures caused by always using keyword-splat forwarding.
JET flags keyword forwarding to T4AMatrixCI.evaluate (which has no keyword methods). Disallow keywords for MatrixCI/MatrixACA forwarding and always call positional-only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR keeps T4ATensorCI backwards compatible while extracting foundational pieces into:
It also fixes local docs builds by developing the local package in the docs environment and avoiding fragile @ref links in extension docstrings.
Related PRs:
Local verification (logs saved):