Skip to content

Conversation

@shinaoka
Copy link
Member

@shinaoka shinaoka commented Jan 1, 2026

This PR moves tensor train representations (VidalTensorTrain, InverseTensorTrain, SiteTensorTrain) from T4AMPOContractions.jl into T4ATensorTrain.jl.

Changes

  • Added VidalTensorTrain, InverseTensorTrain, and SiteTensorTrain types
  • Added helper functions: isleftorthogonal, isrightorthogonal, reshapephysicalleft, reshapephysicalright
  • Extended _factorize to support diamond parameter for VidalTensorTrain construction
  • Added conversion methods between tensor train representations
  • Added comprehensive tests for all representations
  • Updated exports in T4ATensorTrain.jl
  • Fixed JET test configuration

Testing

  • All tests pass (92 tests)
  • Doc build successful
  • No MPI dependencies introduced (as required)

…ntractions

- Move VidalTensorTrain, InverseTensorTrain, and SiteTensorTrain from T4AMPOContractions.jl
- Add helper functions: isleftorthogonal, isrightorthogonal, reshapephysicalleft, reshapephysicalright
- Extend _factorize to support diamond parameter for VidalTensorTrain construction
- Add conversion methods between tensor train representations
- Add comprehensive tests for all representations
- Update exports in T4ATensorTrain.jl
- Fix JET test configuration to use target_modules instead of deprecated target_defined_modules
- Test orthogonality through properly constructed VidalTensorTrain and InverseTensorTrain
- Use 4D tensors (MPO-like) matching the original test pattern
- Add comprehensive tests for singular value contractions
@shinaoka shinaoka merged commit bd4e84b into main Jan 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants