Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tf_gan_on_tpus.ipynb specify TensorFlow version 1.x, update kernel to python3, and correct link #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jherberg462
Copy link

The tf_gan_on_tpus.ipynb colab notebook does not appear to be compatible with TensorFlow 2.

Using tf.compact.v1... on depreciated functionality produces a "RuntimeError: Module must be applied in the graph it was instantiated for" error.

I updated the kernel to python3 as python2 is no longer supported in colab.

The link to the GANEstimator notebook was switched to this notebook in Github. goto.google.com does not appear to be accessible to the public.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no to not pull in to main branch, I think label Apr 28, 2020
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@jherberg462
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes to pull into main branch, I think? and removed cla: no to not pull in to main branch, I think labels Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes to pull into main branch, I think?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants