Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix. #1766

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Quick fix. #1766

merged 1 commit into from
Nov 7, 2023

Conversation

sophiagu
Copy link
Contributor

@sophiagu sophiagu commented Nov 4, 2023

typo

Copy link
Contributor

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

You will need to also change all places that call this property. Otherwise, code breaks.

@sophiagu
Copy link
Contributor Author

sophiagu commented Nov 5, 2023

Let me know if I missed something specifically? From my console, I can only see that all 7 tests have passed. I also did a search within the repo but didn't see other occurrences of this property; it is a private property.

@emilyfertig
Copy link
Contributor

Thanks for the fix! With the typo, tfb.Cumsum._composite_tensor_shape_params would have called the base class's method, which just returns an empty tuple. It makes sense that the overriding method with the typo wouldn't have been called elsewhere. (Ideally our bijector test harness would catch this, since it's a bug in the JAX backend/less efficient in TF to treat axis as a dynamic value, but it currently doesn't). I confirmed that tests pass internally so I'll merge this.

@emilyfertig emilyfertig self-assigned this Nov 7, 2023
@copybara-service copybara-service bot merged commit e0ffe4b into tensorflow:main Nov 7, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants