Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convnext achitecture #354

Conversation

Lorenzobattistela
Copy link
Contributor

@Lorenzobattistela Lorenzobattistela commented Aug 19, 2023

Implementing ConvNeXt architecture referred in this paper and #353 .

Possible reviewer: @owenvallis

P.S - i'm still getting some problems when formatting with black for me a bunch of other files non-related to my changes are changed, so i did not commit them.

@Lorenzobattistela
Copy link
Contributor Author

Weird Pytest output, locally everything just works (except for one test that i did not mess up either):
image

@owenvallis
Copy link
Collaborator

Thanks @Lorenzobattistela! Please update the PR so that it's based off the Development branch and is a merge back into Development. I'll try and take a look into the failing test. That seems like there is a mismatch between the layer config we expect in the test and the one we're seeing in your test. This can happen sometimes when TF updates the base class' save config (we likely only want to check the new fields anyways). Can you share what version of TF you're using when the error pops up? Thanks.

@Lorenzobattistela
Copy link
Contributor Author

Done @owenvallis . Created a new PR based on the dev branch:
#356

#356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants