This repository has been archived by the owner on Jul 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 136
Accurate Tensor.device
for TFEager backends
#1077
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ebf0b87
Remove rm statement
texasmichelle 6a91e58
Merge remote-tracking branch 'upstream/master'
texasmichelle b5de349
Merge remote-tracking branch 'upstream/master'
texasmichelle e3d1347
Merge remote-tracking branch 'upstream/master'
texasmichelle 4b7ec30
Merge remote-tracking branch 'upstream/master'
texasmichelle 4acc515
Merge remote-tracking branch 'upstream/master'
texasmichelle 3500c5a
Merge remote-tracking branch 'upstream/master'
texasmichelle 94e2c75
Merge remote-tracking branch 'upstream/master'
texasmichelle 7a5aebc
Merge remote-tracking branch 'upstream/master'
texasmichelle d49d344
Merge remote-tracking branch 'upstream/master' into eager_device
texasmichelle 673182c
Retrieve device from TFEager libraries
texasmichelle 3547ab1
Move to Tensor.device
texasmichelle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe break this String -> Device out as a separate function?
Also, I'm concerned that the string parsing will be expensive. This function is called a lot. (whenever there is a scalar constant or anything like that). I think it would be best to see if you can add your own TFE_TensorHandleDevice_Type and TFE_TensorHandleDevice_Id. Some benchmarking results might work instead.