PR #14158: Add kExp op to algsimp IsNonNegative #70538
Merged
+206
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
exported_pr_647411876
branch
from
aa70adc
to
e9bbc8c
Compare
Imported from GitHub PR openxla/xla#14158 `kExp` result is always non-negative (similar to `kAbs`). We can add `kExp` to `IsNonNegative()` util function in algsimp Test: ```python import jax.numpy as jnp x = jnp.array([0.0, -0.0, jnp.inf, -jnp.inf, jnp.nan, 0.1, -0.1, 3, -3]) jnp.abs(x) # Array([0. , 0. , inf, inf, nan, 0.1, 0.1, 3. , 3. ], dtype=float32) jnp.exp(x) # Array([ 1. , 1. , inf, 0. , nan, 1.105171, 0.9048374, 20.085537, 0.04978707], dtype=float32) ``` Adrian, what you think? @akuegel Copybara import of the project: -- 401c3e90a1bac7ef4594ad5b6faee5fab4e21871 by Alexander Pivovarov <[email protected]>: Add kExp op to algsimp IsNonNegative and add IsNonNegative tests Merging this change closes #14158 PiperOrigin-RevId: 647502602
copybara-service
bot
force-pushed
the
exported_pr_647411876
branch
from
e9bbc8c
to
c2aa36e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #14158: Add kExp op to algsimp IsNonNegative
Imported from GitHub PR openxla/xla#14158
kExpresult is always non-negative (similar tokAbs).We can add
kExptoIsNonNegative()util function in algsimpTest:
Adrian, what you think? @akuegel
Copybara import of the project:
--
401c3e90a1bac7ef4594ad5b6faee5fab4e21871 by Alexander Pivovarov [email protected]:
Add kExp op to algsimp IsNonNegative
and add IsNonNegative tests
Merging this change closes #14158
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14158 from apivovarov:exp_is_non_negative 401c3e90a1bac7ef4594ad5b6faee5fab4e21871