PR #14224: Fix build error for LogicalIdThunk::buffer_uses() #70548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
exported_pr_647481278
branch
from
3bb25d4
to
e71079d
Compare
Imported from GitHub PR openxla/xla#14224 I tried to build `run_hlo_module` using GCC-13 ```bash bazel build //xla/tools:run_hlo_module ``` and faced build error ```bash xla/service/cpu/runtime/logical_id_thunk.cc:113:18: error: no declaration matches 'xla::cpu::BufferUses<type> xla::cpu::LogicalIdThunk<type>::buffer_uses() const' 113 | BufferUses<type> LogicalIdThunk<type>::buffer_uses() const { | ^~~~~~~~~~~~~~~~~~~~ ``` This PR fixes it by using `Thunk::BufferUses` for the output type of `LogicalIdThunk<type>::buffer_uses()` impl. `BufferUses` alias is declared in `class Thunk` Related issue: openxla/xla#14172 David, Pawel, Can you review the fix? @ddunl @pparuzel Copybara import of the project: -- ac0401cba4fe7c438a426ddd638c8efa9a40f2f3 by Alexander Pivovarov <[email protected]>: Fix build error for LogicalIdThunk::buffer_uses() Merging this change closes #14224 PiperOrigin-RevId: 647497158
copybara-service
bot
force-pushed
the
exported_pr_647481278
branch
from
e71079d
to
ecff54a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #14224: Fix build error for LogicalIdThunk::buffer_uses()
Imported from GitHub PR openxla/xla#14224
I tried to build
run_hlo_moduleusing GCC-13and faced build error
This PR fixes it by using
Thunk::BufferUsesfor the output type ofLogicalIdThunk<type>::buffer_uses()impl.BufferUsesalias is declared inclass ThunkRelated issue: openxla/xla#14172
David, Pawel, Can you review the fix? @ddunl @pparuzel
Copybara import of the project:
--
ac0401cba4fe7c438a426ddd638c8efa9a40f2f3 by Alexander Pivovarov [email protected]:
Fix build error for LogicalIdThunk::buffer_uses()
Merging this change closes #14224
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14224 from apivovarov:fix_logical_id_thunk ac0401cba4fe7c438a426ddd638c8efa9a40f2f3