PR with Publisher Page and Model Markdown #129
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
By opening this pull request, you are agreeing to the TensorFlow Hub Terms of Service at www.tfhub.dev/terms and Google's Privacy Policy at https://www.google.com/policies/privacy, and your pull request is being reviewed. |
| # Publisher steinding | ||
| Stein Ding | ||
|
|
||
| [![Icon URL]](https://drive.google.com/file/d/160VWvcHH6reFYSt6OM9l_-JjQB8HvWUu/view?usp=sharing) |
There was a problem hiding this comment.
It seems like this is not public. Could you double-check?
There was a problem hiding this comment.
Hi WGierke, sorry for the mistake. Now Everyone can check this photo.
There was a problem hiding this comment.
Thank you for the contribution!
I left a few comments. Please let me know if you have any questions!
Also: If you submit assets/docs/steinding/steinding.md in a separate PR, the workflow tests will run automatically on every push of yours and will give you immediate feedback :)
| # Module steinding/yolov5/1 | ||
|
|
||
| Object detection model pretrained on YoloV5. | ||
| <!-- asset-path: https://drive.google.com/drive/folders/1UGiX2CpMVpgRZY1FsdfjOlV9LU9An2HG?usp=sharing --> |
There was a problem hiding this comment.
Could you host it as a tar.gz archive somewhere where the URL ends in tar.gz? Previous publishers e.g. used GCS
There was a problem hiding this comment.
Done, now changed to some GCP storage url
|
|
||
| Object detection model pretrained on YoloV5. | ||
| <!-- asset-path: https://drive.google.com/drive/folders/1UGiX2CpMVpgRZY1FsdfjOlV9LU9An2HG?usp=sharing --> | ||
| <!-- task: Object-detection --> |
There was a problem hiding this comment.
Please change the value to image-object-detection
| <!-- network-architecture: regnety --> | ||
| <!-- format: saved_model_2 --> | ||
| <!-- fine-tunable: true --> | ||
| <!-- license: Anti 996--> |
There was a problem hiding this comment.
Could you please choose a key from https://github.com/tensorflow/tfhub.dev/blob/master/tags/license.yaml? If none matches, please choose "custom" and copy the license to the bottom of this file.
There was a problem hiding this comment.
Please also copy the license that applies to the bottom of the page
There was a problem hiding this comment.
License content is now added to the bottom
DDDSSSTTT
changed the title
|
Hi WGierke, I just add the content of license to the markdown two days ago. Would you please have a look at that if you have the time? |
|
Hi DDDSSSTTT, please understand that we need to review licenses which deviate from the licenses from license.yaml. Unfortunately, I cannot give you an ETA on when the review of the license is completed. |
OK, so if I am using a custom license here. How can I make it to pass the review. Should I do something more than adding the license at the bottom? |
|
If you want to use a custom license that is not one of the OSS licenses from licenses.yaml, we have to send the license to an internal review. There is nothing else you need to do since you already provided the license. |
|
tfhub.dev has been converged with Kaggle Models. You can refer here for an update. Future contributions will be handled by the Kaggle team on https://kaggle.com/models. Thank you! |
Any pull request you open is subject to the TensorFlow Hub Terms of Service at www.tfhub.dev/terms and Google's Privacy Policy at https://www.google.com/policies/privacy.
We check modified Markdown files for validity using this GitHub Workflow. You can execute the same checks locally by passing the file paths of modified Markdown files (relative to the
assets/docsdirectory) to validator.py e.g.python3 ./tools/validator.py google/google.md google/models/albert_base/1.md ....