-
Notifications
You must be signed in to change notification settings - Fork 951
EncodeBase64 and DecodeBase64 ops #1779
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Can you fix the failing errors: https://console.cloud.google.com/gcr/builds/b214fa07-9b38-4194-909d-f5bf95a89811?project=834911136599 Just curious have you tried this in Node, does it work everywhere? Why aren't you using the built in methods to do base64 conversion? |
By the way thanks for the PR! |
@nsthorat my apologies, the errors should be resolved now.
i have added it to the Node kernel (tensorflow/tfjs-node#259) and i tried it out. regarding built in methods are you asking about
because of the em dash/long dash unicode character (i.e., 0x2014). thanks |
Hi @vabarbosa! So @dsmilkov and I just did a deep dive and we have the following conclusions:
We will let you know once string stuff is done! |
thank you! i'll be on the look out for your string tensor updates. and if you have any questions for me in the meantime, feel free to ask. |
Here is the PR if you want to follow: #1816 |
- replace `arrayBufferToString` with `decodeString()` - remove unused `stringToArrayBuffer`
the TF implementation of the pix2pix model which fails conversion because of
the Open NSFW model also fails conversion with some of the same ops (tensorflow/tfjs#433).
i wanted to try to implement some of these ops in TensorFlow.js. starting with this pull request for
DecodeBase64
andEncodeBase64
.along with this
tfjs-core
PR, there is a corresponding PR intfjs-converter
(tensorflow/tfjs-converter#376)To see the logs from the Cloud Build CI, please join either
our discussion
or announcement mailing list.
This change is