Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webcam demo style #40

Merged
merged 6 commits into from
Mar 29, 2018
Merged

Webcam demo style #40

merged 6 commits into from
Mar 29, 2018

Conversation

jimbojw
Copy link
Contributor

@jimbojw jimbojw commented Mar 29, 2018

Implemented a glow to highlight the selected/predicted button both during collection and during game play.


This change is Reviewable

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@nsthorat
Copy link

:lgtm_strong:

Thanks Jimbo!!


Review status: 0 of 3 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@dsmilkov
Copy link
Contributor

:lgtm_strong: Thank you!


Reviewed 2 of 3 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@nsthorat nsthorat merged commit d320351 into master Mar 29, 2018
@nsthorat nsthorat deleted the webcam-demo-style branch March 29, 2018 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants