Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tfjs-core] linalg.bandPart: Added bandPart to tfjs-core #2155

Closed
wants to merge 3 commits into from

Conversation

Kriyszig
Copy link
Contributor

@Kriyszig Kriyszig commented Oct 6, 2019

Issue: #1969

Added bandPart to linalg operationa. Added tests to check correctness and consistency. If any changes are required, please let me know and I'll make them ASAP! :octocat:


This change is Reviewable

@Kriyszig
Copy link
Contributor Author

Kriyszig commented Oct 6, 2019

Chrome Mobile is throwing an error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL. which seems to be completely unrelated to this PR because it doesn't involve bandPart however I'm not 100% sure

@Kriyszig Kriyszig changed the title linalg.bandPart: Added bandPart to tfjs-core [tfjs-core] linalg.bandPart: Added bandPart to tfjs-core Oct 6, 2019
@Kriyszig
Copy link
Contributor Author

A more efficient implementation can be found in #2226 🥇
Closing this PR in favour of the above :octocat:

@Kriyszig Kriyszig closed this Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants