[Local benchmark tool] Add parallel compile option #7755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunnienc
approved these changes
Jun 13, 2023
qjia7
reviewed
Jun 14, 2023
| throw new Error( | ||
| 'Parallel Compilation for async function is not supported.'); | ||
| } | ||
| res = await res; |
There was a problem hiding this comment.
Why we need an extra res = await res? And is it possible that res is a tensor array so that we can't directly call tf.dispose(res)?
There was a problem hiding this comment.
Why we need an extra res = await res?
I am adding it in case predict is a async function
And is it possible that res is a tensor array so that we can't directly call tf.dispose(res)?
I think tf.dispose is able to process tensor container, https://js.tensorflow.org/api/latest/#dispose
qjia7
approved these changes
Jun 24, 2023
| throw new Error( | ||
| 'Parallel Compilation for async function is not supported.'); | ||
| } | ||
| res = await res; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the name
Warm up timewith1st inference time, because theWarm up timename is confusing: the number of warm up runs could be many andWarm up timeactually presents the1st inference time.The parallel compilation feature has effects only for WebGL backend and WebGPU backend.
UI Preview:
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.