This repository has been archived by the owner on Jul 22, 2022. It is now read-only.
And there we go... again! #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueldurantes
approved these changes
Sep 9, 2020
samueldurantes
approved these changes
Sep 9, 2020
samueldurantes
approved these changes
Sep 9, 2020
|
I put it back in place, it seems that not everything is roses. |
ruj
commented
Sep 10, 2020
lib/WaifuPics.js
Outdated
Comment on lines
49
to
51
| WaifuPics[type][category] = () => request('GET', endpoint) | ||
| WaifuPics.many[type][category] = (exclude) => request('POST', '/many' + endpoint, { body: JSON.stringify({ exclude }) }) | ||
| }) |
There was a problem hiding this comment.
This is the best so far, maybe it will improve further.
There was a problem hiding this comment.
I don't know if exclude images is effective, I tried to eliminate a large scale of images to see where we were going but it seems to be large enough to always return others
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this is an upgrade or a downgrade, very confusing.
I removed the parseResponse, now it seems that some things have improved in the api. What used to be text/plain now seems to be all content json, what a relief.
We still need to complement with the "new" final route, I just want to see this it soon. OMEGALUL