-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MIRI to CI and fix UB #63
Conversation
Could you force-push the commits again? CI seems to be stuck and I think that should re-trigger it. |
I've tried force pushing, and adding a nop commit, but neither seems to have unstuck CI - is it because I added MIRI to the github actions, which is theoretically insecure to run without approval? Do you need to sign off on my workflow changes somehow before checks will run? |
Co-authored-by: Teodor Tanasoaia <[email protected]>
Cheers! Silly mistake. Now it's failing on unstable library functions due to the old(er) nightly build being used to test - issue 86161 was stabilized July of last year. Since the latest stable release is about a year more recent than the nightly being used in the CI, I'll promote the nightly by a few months to match the latest stable release (1.75.0, 2023-12-28). |
Sounds good, the versions are pinned just to avoid random breakages. |
It would be nice if GitHub actually told us: "Hey the workflow file is invalid!" in big red text 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Resolves #62