Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MIRI to CI and fix UB #63

Merged
merged 6 commits into from
Jan 9, 2024
Merged

Add MIRI to CI and fix UB #63

merged 6 commits into from
Jan 9, 2024

Conversation

Joeoc2001
Copy link
Contributor

@Joeoc2001 Joeoc2001 commented Jan 8, 2024

Resolves #62

@teoxoy
Copy link
Owner

teoxoy commented Jan 9, 2024

Could you force-push the commits again? CI seems to be stuck and I think that should re-trigger it.

@Joeoc2001
Copy link
Contributor Author

I've tried force pushing, and adding a nop commit, but neither seems to have unstuck CI - is it because I added MIRI to the github actions, which is theoretically insecure to run without approval? Do you need to sign off on my workflow changes somehow before checks will run?

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Co-authored-by: Teodor Tanasoaia <[email protected]>
@Joeoc2001
Copy link
Contributor Author

Cheers! Silly mistake.

Now it's failing on unstable library functions due to the old(er) nightly build being used to test - issue 86161 was stabilized July of last year. Since the latest stable release is about a year more recent than the nightly being used in the CI, I'll promote the nightly by a few months to match the latest stable release (1.75.0, 2023-12-28).

src/utils.rs Outdated Show resolved Hide resolved
@teoxoy
Copy link
Owner

teoxoy commented Jan 9, 2024

Sounds good, the versions are pinned just to avoid random breakages.

@teoxoy
Copy link
Owner

teoxoy commented Jan 9, 2024

It would be nice if GitHub actually told us: "Hey the workflow file is invalid!" in big red text 😅

Copy link
Owner

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@teoxoy teoxoy merged commit 148b61b into teoxoy:main Jan 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MIRI reports UB on <Vec<u8> as ByteVecExt>::try_extend_zeroed
2 participants