-
Notifications
You must be signed in to change notification settings - Fork 6
Junit5 migration #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Junit5 migration #16
Conversation
- Also includes minor enhancements to tests
7056f22
to
87bf3da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments about the general quality of the unit tests which might be outside of to the scope of this PR. So you can resolve them with an new issue.
- Now in use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Rebase main to this branch, after Fix mocking #15 is merged
Migrates JUnit 4 assertions to JUnit 5 assertions
Will close Migrate from JUnit 4 to JUnit 5 #14