Fix SAMS match loading for null team MVP fields - #49
Merged
Conversation
Unplayed league matches return team1Mvp/team2Mvp as null; the generated Zod schema rejected those responses and dropped match pages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nullforteam1Mvp/team2Mvpin the SAMS OpenAPI client patch (same$refnullable pattern asresults/referees/location).Same fix as terijaki/vcmuellheim#376.
Test plan
LeagueMatchDtowithteam1Mvp: null/team2Mvp: nullsucceeds after regengetAllLeagueMatchesresponses for the current season include null MVP fields and no longer fail response validation/matches, homepage Heimspiele, team pages) show upcoming fixtures