Deepen SAMS match loading and harden SSR cache-peek paths - #375
Merged
Conversation
Consolidate match loading and teams sync in lib/sams, enforce cache-peek SSR loaders, and delete unused read handlers.
Move match loading into the app server layer, route SSR through createServerFn, and tighten shared club/filter helpers with tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sams-match-loader.server.ts, move teams sync intolib/sams, and remove undeployed read Lambdas.Promise.allSettledon public routes, and effective-input fallback when DynamoDB/cache peek fails.staleTimewith the 5‑minute match cache TTL; clarify season disagreement (majority / most-recent) in ADR +CONTEXT.md.AWS_REGION).Test plan
vp checkandvp testpassbun run test:e2e e2e/sams-smoke.spec.ts— homepage +/terminepass without AWS; DynamoDB cases skip unlessAWS_REGION/WEBAPP_URLagainstvprserver/termine,/tabelle,/teams/$slugload without callinggetSamsMatchesFnin loaders; empty SAMS sync still renders page shellsfor-seasonon cache miss