Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypy: fix build #21026

Merged
merged 1 commit into from
Aug 2, 2024
Merged

pypy: fix build #21026

merged 1 commit into from
Aug 2, 2024

Conversation

licy183
Copy link
Member

@licy183 licy183 commented Aug 2, 2024

Part of #20966

@Biswa96
Copy link
Member

Biswa96 commented Aug 2, 2024

There is an issue about os.setxattr in pypy. Should it be fixed here?

@licy183
Copy link
Member Author

licy183 commented Aug 2, 2024

There is an issue about os.setxattr in pypy. Should it be fixed here?

It have been fixed in this PR.

Emmm... It is related to pypy3 rather than pypy. I'll fix it in next PR.

--- a/rpython/rlib/rposix.py
+++ b/rpython/rlib/rposix.py
@@ -3086,7 +3086,7 @@
 # ____________________________________________________________
 # Support for *xattr functions

-if sys.platform.startswith('linux'):
+if False:

     class CConfig:
         _compilation_info_ = ExternalCompilationInfo(

@licy183 licy183 linked an issue Aug 2, 2024 that may be closed by this pull request
@licy183 licy183 merged commit df4b49c into master Aug 2, 2024
5 checks passed
@licy183 licy183 deleted the pypy-rebuild branch August 2, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants