Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the signing keys info for each repo channel to repo json file #21181

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Move the signing keys info for each repo channel to repo json file #21181

wants to merge 2 commits into from

Commits on Aug 22, 2024

  1. scripts(build-package.sh): move the signing keys info for each repo c… 

    …hannel to `repo.json` instead of hardcoding it in build scripts

This will allow each repo channel to define its own keys that may be used for verifying signatures of its files. The `termux-packages` fork will just need to add signing keys info in the `repo.json` file itself for any additional channels instead of having to patch build scripts. With the old hardcoded way, the unnecessary pacman key was also being added to local keystore in the current/upstream termux-packages repo, even though no repo channel uses it, so defining the keys in the `repo.json` will solve that issue as well.

The `termux_repository__add_repo_signing_keys_to_keystore()` function now handles the logic for adding the repository signing keys to the local keystore. Check its function docs for more info on the new json format and requirements for `repo.json` file.
    @agnostic-apollo @Maxython
    agnostic-apollo authored and Maxython committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    241a3c2 View commit details
    Browse the repository at this point in the history

  2. Improving PR 

    The point of this Improving PR is to provide the previous changes in a simpler form, but at the same time maintaining the functionality and capabilities.
    @Maxython
    Maxython committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    c8600d2 View commit details
    Browse the repository at this point in the history