-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump libllvm and flang from 18.1.8 to 19.1.0 #21452
base: master
Are you sure you want to change the base?
Conversation
d162d9f
to
4df1894
Compare
AArch64 built and runs fine, so building the rest now. |
Alright, the upcoming LLVM 19 release builds and works fine. @truboxl, @licy183 and @TomJo2000, you may want to start trying to build the rust, zig, and flang compilers with these new packages: simply download the zip file from the CI and unpack the |
I just need to update the |
LLVM 19.1.0 will be released in the next couple days. I see only two compilers that dynamically link against it and which would break on the update: crystal and rust. @HertzDevil, do you know if crystal will rebuild fine against the next LLVM release? @truboxl, get a chance to try rebuilding rust yet with this update? |
We have a pending PR for Crystal that was last known to work with some x86-64 Debian release after 19.1.0-rc1. Our next minor release is scheduled for Oct 9th, although that PR needs to land before 25th this month. I do not believe there are any AArch64-specific blockers. |
I do not understand what makes this branch so special that
EDIT: ah might be the blacklist arch |
Yeah, just remove that line. I didn't want to rebuild AArch64 unnecessarily, as I had already built it first. |
Rust should be ready for LLVM 19 with next version 1.82, scheduled for October 17: https://releases.rs/docs/1.82.0/ |
That's way too long, is there a LLVM 19 pull we can backport instead? |
Rebased to fix CI issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... actually it might be an issue with include path priorities? we'll see if anything else is missing idioms.h stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this patch doesn't work, no need to keep trying on this pull, as the CI has to keep building LLVM first. We can just open a separate flang pull later, once this is in.
We can try build rust 1.82.0 beta but I have no idea why the build broke.
|
I am surprised the Rust team is waiting so long after the initial LLVM 19 patch release to support it. It would be better if there's an upstream pull you could backport to 1.81. I think somebody did that before for us and it wasn't a massive patch or anything, but I didn't look closely. |
I'll take a look this weekend. |
@licy183, assuming this passes CI, please squash the last three commits to a single commit authored by you, though with the simple commit message I wrote, since you got flang working. I will then add in the final llvm-config script changes and merge this weekend. |
Let's see if it builds for AArch64 still, haven't tried this at all locally.