Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new package: qt6-qt5compat #21573

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

new package: qt6-qt5compat #21573

wants to merge 1 commit into from

Conversation

knyipab
Copy link
Contributor

@knyipab knyipab commented Sep 25, 2024

Grateful for considering to merge this.

I am trying to build krita with all deps ready, but this qt6-qt5compat cannot be built together in one PR, cuz other krita deps (of deps) requires qt5-qtbase which messes up the build process of qt6-qt5compat. Merging this PR is needed in order to proceed to building krita (though using krita git qt6 version. Cuz termux's qt5 doesn't support opengl and won't build).

Deps and build deps take ref to https://archlinux.org/packages/extra/x86_64/qt6-5compat/ and also verified to be sufficient by looking at its cmakelists.txt

Copy link
Member

@TomJo2000 TomJo2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do you have any particular package in mind that required qt5compat?

@knyipab
Copy link
Contributor Author

knyipab commented Sep 26, 2024

Krita (git ver, for now, enough to prove qt6-qt5compat working). I have all deps ready in this branch, just qt6-qt5compat building messed up by other deps, shown at this GitHub action.

A lot of kf6 packages seem to need qt6-qt5compat.

@truboxl
Copy link
Contributor

truboxl commented Sep 26, 2024

Please move qt6-qtdeclarative to DEPENDS.
I can see
lib/qt6/qml/Qt5Compat/GraphicalEffects/libqtgraphicaleffectsplugin.so and lib/qt6/qml/Qt5Compat/GraphicalEffects/private/libqtgraphicaleffectsprivateplugin.so
needs libQt6Qml.so.6.

@knyipab
Copy link
Contributor Author

knyipab commented Sep 26, 2024

I did that only becuz archlinux state it as optional "qt6-declarative (optional) - for QtGraphicalEffects" and they also have the mentioned .so files in the package.

I have no strong view and termux may have different philosophy. May I just confirm once that it is more preferred to move qt6-qtdeclarative to DEPENDS?

Thank you : )

@knyipab
Copy link
Contributor Author

knyipab commented Sep 27, 2024

Ok, I assume that you still want to put it in the DEPENDS, so I edited. Let me know for any issues before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants