Skip to content

Conversation

@robertkirkman
Copy link
Member

@robertkirkman
Copy link
Member Author

robertkirkman commented Jul 17, 2025

It is working, so I will merge it in 24 hours if no problems are found.

There is a precedent of one package not working properly with libandroid-spawn, fish 4.0+.

There is not currently any precedent known to me of libandroid-spawn not working with any other package.

Here is some more information about the problem that occurred when fish and libandroid-spawn were combined #22609 (comment)

In this case, the package appears to be working properly with libandroid-spawn, and is not a Rust program, so I do not think there is a high risk of a similar problem occurring for this package.

@robertkirkman
Copy link
Member Author

Upstream might not approve of this PR because of them voicing disappointment with the nature of the libandroid-spawn library, so I will prefer to wait to read their responses about this subject before applying this update.

@robertkirkman robertkirkman marked this pull request as draft July 17, 2025 23:52
@robertkirkman robertkirkman force-pushed the fastfetch-2.48.0 branch 2 times, most recently from fa74d52 to 1c52b33 Compare July 18, 2025 03:14
@robertkirkman robertkirkman changed the title bump(main/fastfetch): 2.48.0 [draft] bump(main/fastfetch): 2.48.0 Jul 18, 2025
@robertkirkman robertkirkman changed the title [draft] bump(main/fastfetch): 2.48.0 [draft] bump(main/fastfetch): 2.48.0-p20250717 Jul 18, 2025
@robertkirkman
Copy link
Member Author

robertkirkman commented Jul 18, 2025

Upstream has decided to place a change in upstream code that automatically reverts the change that broke auto updating when targeting Android is detected.

This means that the current version of fastfetch should be skipped for packaging here, and the next version should be waited for and packaged instead.

I have changed this PR into a test build of the development branch of fastfetch, which will eventually become the next version when it is ready.

@robertkirkman robertkirkman changed the title [draft] bump(main/fastfetch): 2.48.0-p20250717 bump(main/fastfetch): 2.48.1 Jul 18, 2025
@robertkirkman robertkirkman marked this pull request as ready for review July 18, 2025 14:21
@robertkirkman
Copy link
Member Author

Upstream has made a release with everything fixed and I think it is ready now, so I will merge this in 24 hours if no other problems are found.

Copy link
Member

@TomJo2000 TomJo2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead with merge when ready.

@robertkirkman robertkirkman merged commit 62fd0e3 into termux:master Jul 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto update failing for fastfetch

3 participants