Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cargo generate #63

Merged
merged 11 commits into from
May 27, 2022
Merged

Replace cargo generate #63

merged 11 commits into from
May 27, 2022

Conversation

emidev98
Copy link
Contributor

@emidev98 emidev98 commented May 5, 2022

This PR will replace cargo generate with template-scaffolding which is a native JavaScript solution to clone templates and replace the tags from the template with necessary values send as config object.

@emidev98 emidev98 force-pushed the feat_replace-cargo-generate branch 3 times, most recently from d3eef0a to 4d0492f Compare May 9, 2022 08:41
@emidev98
Copy link
Contributor Author

emidev98 commented May 9, 2022

@emidev98 emidev98 marked this pull request as ready for review May 9, 2022 09:33
@emidev98 emidev98 changed the title wip: replace cargo generate Replace cargo generate May 9, 2022
@octalmage
Copy link
Contributor

@emidev98 would you mind running the eslint fix on both code new and the new command? Lots of issues with the style.

@emidev98
Copy link
Contributor Author

emidev98 commented May 10, 2022

@octalmage I created this issue to modify all staying in only one PR when we have less PRS open #69. Does it make more sense? Since we have many linings that should be fixed

@octalmage
Copy link
Contributor

It makes the code harder to review, might as well start fixing our code moving forward!

@emidev98
Copy link
Contributor Author

Makes totally sense it looked horrible, I have fixed all of them minus https://github.com/terra-money/terrain/security/code-scanning/678, which if I am not mistaking we are addressing it in another branch. Let me know @octalmage 👍

Copy link
Contributor

@octalmage octalmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@octalmage octalmage force-pushed the feat_replace-cargo-generate branch from aed8534 to 9cb7ebb Compare May 27, 2022 06:36
@octalmage octalmage merged commit c253a8f into main May 27, 2022
@octalmage octalmage deleted the feat_replace-cargo-generate branch May 27, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants