feat!: Update AWS provider to support v5.0 and increase Terraform MSV to 1.0
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pending testing and validation |
bryantbiggs
force-pushed
the
feat/updates
branch
2 times, most recently
from
2ff9893
to
2bdf65d
Compare
|
Hey @bryantbiggs any changes to have it approved? I'm looking to the fix of "ignore_header_rows". |
3 tasks
bryantbiggs
force-pushed
the
feat/updates
branch
from
2bdf65d
to
b121e86
Compare
antonbabenko
approved these changes
Aug 23, 2023
|
|
||
| db_name = "example" | ||
| db_username = "example" | ||
| db_password = "password123!" # do better! |
There was a problem hiding this comment.
examples/complete/main.tf
Outdated
|
|
||
| tags = local.tags | ||
| } | ||
|
|
||
| module "msk_cluster" { | ||
| source = "clowdhaus/msk-kafka-cluster/aws" |
There was a problem hiding this comment.
Suggested change
| source = "clowdhaus/msk-kafka-cluster/aws" | |
| source = "terraform-aws-modules/msk-kafka-cluster/aws" |
versions.tf
Outdated
| } | ||
| time = { | ||
| source = "hashicorp/time" | ||
| version = ">=0.7.2" | ||
| version = ">=0.9" |
There was a problem hiding this comment.
Suggested change
| version = ">=0.9" | |
| version = ">= 0.9" |
antonbabenko
pushed a commit
that referenced
this pull request
Aug 23, 2023
## [2.0.0](v1.6.1...v2.0.0) (2023-08-23) ### ⚠ BREAKING CHANGES * Update AWS provider to support `v5.0` and increase Terraform MSV to `1.0` (#42) ### Features * Update AWS provider to support `v5.0` and increase Terraform MSV to `1.0` ([#42](#42)) ([6fea0da](6fea0da)) ### Bug Fixes * Fixes small README typos ([#37](#37)) ([f67f77d](f67f77d))
|
This PR is included in version 2.0.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
v5.0and increase Terraform MSV to1.0s3_settingsfromaws_dms_endpointand useaws_dms_s3_endpointinstead per AWS provider directionredshift_settingsonaws_dms_endpointMotivation and Context
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request