-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Add support for Log Analytics and Remove BigQuery log destination #1025
feat!: Add support for Log Analytics and Remove BigQuery log destination #1025
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only concern I had the change would trigger a removal of the BQ dataset, but I only saw the change to the log filter.
@jasonbisson This change removed the direct export to a BigQuery dataset that existed previously from the main code and from the inner module we use. If this new version would be applied over a deployed version of the This is the reason for the There is no in-place upgrade path from the a version of the foundation to a new version . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@gtsorbo @apeabody @bharathkkb build is green :) |
This PR adds support for Log Analytics in the Log Bucket destination and removes the BigQuery log destination from the centralized logging configured in step
1-org
.Now that Log Analytics is available in GA, the same use cases for analytics that were previously accomplished using a log sink export to BigQuery can now be accomplished with a log sink export to a Logging bucket.
This change helps address use cases for both writing custom SQL queries for deep analysis analysis and ad-hoc investigation using the Logs Explorer console, with one single log sink and data source instead of two.
For more information on the differences of these log sink types see Moving to Log Analytics for BigQuery export users